Project

General

Profile

« Previous | Next » 

Revision 14470

Added by Aaron Marcuse-Kubitza over 10 years ago

fix: lib/tnrs.py: retrieval_request_template: source_sorting (Constrain by Source): corrected explanation to reflect that the behavior is actually the same in both modes, since only one match is ever marked as selected, and that match should always come first

View differences:

trunk/lib/tnrs.py
48 48 
	# taxonomic_constraint (Constrain by Higher Taxonomy): selects lower ranks
49 49 
	#  only from within the matched higher ranks. must be turned on, to ensure
50 50 
	#  that higher ranks are always authoritative.
51 
	# source_sorting (Constrain by Source):
52 
	#  has different behavior depending on the match mode:
53 
	#  - in all-matches mode (`"mode":"All"` @ download_request_template):
54 
	#    always puts matches in the order of the sources. although the 1st match
55 
	#    won't necessarily be the best one, the 1st match *with Selected=true*
56 
	#    will be (according to the source sort order). must be turned on, so
57 
	#    that the selected matches are sorted by source.
58 
	#  - in best-match mode (`"mode":"Best"` @ download_request_template):
59 
	#    always selects a match from the first source in the list, no matter how
60 
	#    low the match score. must be turned *off* (unlike in all-matches mode),
61 
	#    to avoid worse matches being selected instead of better ones.
62 
	#    *however*, since this is currently broken and always on, we turn it on
63 
	#    so that the download settings reflect what TNRS actually used.
51 
	# source_sorting (Constrain by Source): always puts matches in the order of
52 
	#  the sources, regardless of match score. should never be turned on,
53 
	#  because it selects worse matches instead of better ones. *however*, since
54 
	#  this is currently broken and always forced on, we turn it on so that the
55 
	#  download settings reflect what TNRS actually used.
64 56 
retrieval_response_pattern = '^//OK\[.*?\["com.extjs.gxt.ui.client.data.\
65 57 
BasePagingLoadResult/496878394","java.util.ArrayList/4159755760","org.iplantc.\
66 58 
tnrs.demo.shared.BeanTNRSEntry/1039545748",".*"\],0,7\]$'

Also available in: Unified diff