Project

General

Profile

# Date Author Comment
12485 02/25/2014 10:49 PM Aaron Marcuse-Kubitza

schemas/util.sql: removed no longer used mk_use_own_schema(). use util.use_own_schema() instead.

12484 02/25/2014 10:48 PM Aaron Marcuse-Kubitza

schemas/util.sql, vegbien.sql: use util.use_own_schema()/util.set_search_path() instead of EXECUTE util.mk_use_own_schema()/util.mk_set_search_path()

12483 02/25/2014 10:42 PM Aaron Marcuse-Kubitza

schemas/util.sql: added use_own_schema()

12482 02/25/2014 10:40 PM Aaron Marcuse-Kubitza

schemas/util.sql: added set_search_path()

12481 02/25/2014 10:36 PM Aaron Marcuse-Kubitza

schemas/util.sql: runnable_sql(): don't output search_path before a SET statement

12480 02/25/2014 10:31 PM Aaron Marcuse-Kubitza

schemas/util.sql: added is_set_stmt()

12479 02/25/2014 09:28 PM Aaron Marcuse-Kubitza

schemas/util.sql: diff(text, text): use mk_diff_query()'s new cols param to avoid a nested SELECT

12478 02/25/2014 09:17 PM Aaron Marcuse-Kubitza

schemas/util.sql: mk_diff_query(): parameterized the customizable parts of the query, to allow them to be replaced with their EXPLAIN expansion (which is what we ultimately want, so that the query does not refer to any internal tables or views)

12477 02/25/2014 09:02 PM Aaron Marcuse-Kubitza

schemas/util.sql: diff(text, text): use util.mk_diff_query(). this splits the complex query-generation code apart from the query-execution code.

12476 02/25/2014 08:51 PM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: undid r12472 because the command needed to limit the effects of any `SET LOCAL search_path` to the current function will unfortunately also clear any existing search_path, which may be needed for the eval query to execute

12475 02/25/2014 08:25 PM Aaron Marcuse-Kubitza

schemas/util.sql: added mk_diff_query()

12474 02/25/2014 08:13 PM Aaron Marcuse-Kubitza

schemas/util.sql: debug_print_sql(): use runnable_sql()

12473 02/25/2014 08:12 PM Aaron Marcuse-Kubitza

schemas/util.sql: added runnable_sql()

12472 02/25/2014 08:07 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: eval2*(): added search_path function option in order to limit the effects of any `SET LOCAL search_path` in the invoked query to the current function. however, plain eval() is not changed because it is often used to execute a `SET LOCAL search_path` in the calling function.

12471 02/25/2014 06:03 PM Aaron Marcuse-Kubitza

schemas/util.sql: diff(text, text): removed unnecessary casts to the base type in the join condition and the WHERE filter. these had been presumed necessary due to errors, but the errors turned out to be caused by the operator not being in the search_path. note that the casts in the columns list are still needed, as described in the associated comment.

12470 02/25/2014 05:40 PM Aaron Marcuse-Kubitza

schemas/util.sql: materialize_query(): add a comment on the table with the query it was generated from

12469 02/25/2014 05:39 PM Aaron Marcuse-Kubitza

schemas/util.sql: debug_print_sql(): util.mk_set_search_path(): use for_printing := true to comment out LOCAL

12468 02/25/2014 04:11 PM Aaron Marcuse-Kubitza

schemas/util.sql: mk_set_search_path(text): include LOCAL commented out, because the user might want to run it with another statement as a single command, in which case it would be useful because they will be in the same transaction (http://www.postgresql.org/docs/9.3/static/sql-set.html#AEN81154)

12467 02/25/2014 04:09 PM Aaron Marcuse-Kubitza

schemas/util.sql: mk_set_search_path(): added for_printing option like for mk_set_search_path(text)

12466 02/25/2014 04:04 PM Aaron Marcuse-Kubitza

schemas/util.sql: mk_set_search_path(): support creating a SET search_path statement for display as well, which would exclude LOCAL because it doesn't work as a standalone command (http://www.postgresql.org/docs/9.3/static/sql-set.html#AEN81154)

12465 02/25/2014 02:48 PM Aaron Marcuse-Kubitza

schemas/util.sql: debug_print_sql(): include the search_path in case the query contains search_path-dependent elements (such as operators)

12464 02/25/2014 02:45 PM Aaron Marcuse-Kubitza

schemas/util.sql: util.explain2notice_msg(): add newline before and after to visually separate it from other debug info

12463 02/25/2014 02:30 PM Aaron Marcuse-Kubitza

schemas/util.sql: added mk_set_search_path() (which uses the current search_path)

12462 02/25/2014 02:08 PM Aaron Marcuse-Kubitza

schemas/util.sql: diff(text, text): in the outputted FULL JOIN query, documented that you should refer to the EXPLAIN output for the expansion of %==

12461 02/25/2014 01:54 PM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: first_word(): ignore leading whitespace: need to use util.ltrim_nl(), as ltrim() only removes spaces

12460 02/25/2014 01:46 PM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: first_word(): need to ignore leading whitespace. this applies to many of our queries, which have a leading newline.

12459 02/25/2014 01:44 PM Aaron Marcuse-Kubitza

schemas/util.sql: explain(): don't debug-print the EXPLAIN, to avoid cluttering up the debug output

12458 02/25/2014 01:41 PM Aaron Marcuse-Kubitza

schemas/util.sql: eval2set(): make debug-printing optional, for use with internal statements

12457 02/25/2014 01:28 PM Aaron Marcuse-Kubitza

schemas/util.sql: added is_explain()

12456 02/25/2014 01:25 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: diff(text, text): FULL JOIN SELECT statement: don't put a comment at the very beginning, because this prevents it from being autoexplained (this is the query we particularly want EXPLAIN output for)

12455 02/25/2014 01:22 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: debug_print_sql(): only surround EXPLAIN output with newlines if there is any

12454 02/25/2014 01:19 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: debug_print_sql(): need newline before and after EXPLAIN output to visually separate it from other debug info

12453 02/25/2014 01:06 PM Aaron Marcuse-Kubitza

schemas/util.sql: util.debug_print_sql(): include the EXPLAIN output of applicable queries, for easier query plan debugging (just like lib/sql.py's db.autoexplain)

12452 02/25/2014 01:02 PM Aaron Marcuse-Kubitza

schemas/util.sql: added explain2notice_msg_if_can()

12451 02/25/2014 12:57 PM Aaron Marcuse-Kubitza

schemas/util.sql: added is_explainable(sql)

12450 02/25/2014 12:55 PM Aaron Marcuse-Kubitza

schemas/util.sql: added first_word()

12449 02/25/2014 12:25 PM Aaron Marcuse-Kubitza

schemas/util.sql: explain2notice(): use util.raise_notice()

12448 02/25/2014 12:23 PM Aaron Marcuse-Kubitza

schemas/util.sql: explain2notice(): added helper function explain2notice_msg() which can also be used individually

12447 02/25/2014 12:21 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: schema comment: noted that avoiding use of STRICT also makes functions much easier to troubleshoot, because they won't mysteriously do nothing if called with only NULL arguments, even when you have added debug-print statements

12446 02/25/2014 12:19 PM Aaron Marcuse-Kubitza

schemas/util.sql, vegbien.sql: do not declare any SQL-language functions as STRICT, because this prevents them from being inlined (as documented in the util schema comment). the STRICT qualifier has been preserved where its behavior is necessary, rather than just used for optimization.

12445 02/25/2014 12:09 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: schema comment: indicate that all SQL-language functions should never be declared STRICT, not just IMMUTABLE ones, since inlining is not limited to IMMUTABLE (or STABLE) functions (although constant folding is)

12444 02/25/2014 12:07 PM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: join_strs_transform(): added back STRICT qualifier because it must be declared STRICT to use the special handling of STRICT aggregating functions

12443 02/25/2014 11:56 AM Aaron Marcuse-Kubitza

schemas/util.sql: %==(anyelement, anyelement): needs to be declared STABLE instead of IMMUTABLE because it depends on the search_path (as described at http://vegpath.org/links/#PostgreSQL:%20Documentation:%209.3:%20Function%20Volatility%20Categories%20**)

12441 02/25/2014 11:37 AM Aaron Marcuse-Kubitza

schemas/util.sql, vegbien.sql: do not declare IMMUTABLE SQL-language functions as STRICT, because this prevents them from being inlined (as documented in the util schema comment)

12439 02/25/2014 10:55 AM Aaron Marcuse-Kubitza

fix: schemas/util.sql: diff(text, text): use util.typeof() instead of pg_typeof() so the outputted query is runnable in any search_path

12438 02/25/2014 10:50 AM Aaron Marcuse-Kubitza

schemas/util.sql: added typeof(), which unlike pg_typeof() uses util.qual_name() to create a search_path-independent name

12437 02/25/2014 10:33 AM Aaron Marcuse-Kubitza

fix: schemas/util.sql: quote_typed(): schema-qualify the type so the expression does not depend on the search_path

12436 02/25/2014 10:31 AM Aaron Marcuse-Kubitza

schemas/util.sql: %== : use custom keys() function for the type, so that the user only has to get the keys from their value, not also write the comparison of those keys

12434 02/25/2014 10:12 AM Aaron Marcuse-Kubitza

schemas/util.sql: diff(regclass, regclass): support custom %== by including the col_type_null's schema in the search_path

12433 02/25/2014 10:07 AM Aaron Marcuse-Kubitza

schemas/util.sql: debug_print_return_value(): don't '-encode the value by default, because text values usually look better without the '-escaping

12432 02/25/2014 09:55 AM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: mk_set_search_path(): debug_print_return_value() needs to be on mk_set_search_path(text), not mk_search_path(VARIADIC text[])

12431 02/25/2014 09:45 AM Aaron Marcuse-Kubitza

schemas/util.sql: mk_search_path(): use debug_print_return_value() because this function is used with EXECUTE rather than util.eval() (in order to affect the calling function), so the search_path would not otherwise be printed

12430 02/25/2014 09:39 AM Aaron Marcuse-Kubitza

schemas/util.sql: added debug_print_return_value()

12429 02/25/2014 09:34 AM Aaron Marcuse-Kubitza

schemas/util.sql: diff(text, text): support custom search_path because custom %== operators are usually not in the util schema

12428 02/25/2014 09:28 AM Aaron Marcuse-Kubitza

schemas/util.sql: diff(text, text): renamed IN params to be different from OUT params to support LANGUAGE plpgsql

12427 02/25/2014 09:04 AM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: diff(*): changed from STABLE to VOLATILE because these functions create tables

12424 02/25/2014 07:42 AM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: diff(text, text) and types that use its custom FULL JOIN matching: need to use separate operator %== for determining which records to put on the same row, so that the = filter for identical rows only excludes rows that are actually the same, not all rows with the same keys (which would usually remove all rows)

12423 02/25/2014 07:21 AM Aaron Marcuse-Kubitza

schemas/util.sql: added operator %== , which returns whether the map-keys of the compared values are the same

12420 02/25/2014 12:16 AM Aaron Marcuse-Kubitza

schemas/util.sql: diff(): support custom = operator for the table type (to FULL JOIN on only some columns). this requires casting to the base type, to avoid an ambiguity with the default = operator for record.

12419 02/24/2014 11:18 PM Aaron Marcuse-Kubitza

schemas/util.sql: remake_diff_table(): use util.quote_typed() instead of hardcoding the type

12413 02/24/2014 04:43 PM Aaron Marcuse-Kubitza

schemas/util.sql: added drop_relations_like()

12385 02/23/2014 07:23 PM Aaron Marcuse-Kubitza

schemas/util.sql: show_views_like(): take a schema regexp like util.show_relations_like(), to allow matching views in all schemas

12384 02/23/2014 07:19 PM Aaron Marcuse-Kubitza

schemas/util.sql: added str_equality_regexp(literal text)

12382 02/23/2014 06:50 PM Aaron Marcuse-Kubitza

schemas/util.sql: util.remake_diff_table(): don't force-re-create type_table. this allows type_table to be shared between multiple diff tables.

12378 02/23/2014 05:08 PM Aaron Marcuse-Kubitza

schemas/util.sql: added curr_func(func text, schema_anchor anyelement)

12377 02/23/2014 03:50 PM Aaron Marcuse-Kubitza

schemas/util.sql: removed unneeded regproc(regprocedure), regprocedure(regproc) because these can actually be directly cast to one another, not just via oid

12376 02/23/2014 03:47 PM Aaron Marcuse-Kubitza

schemas/util.sql: added quote_func_call()

12375 02/23/2014 03:22 PM Aaron Marcuse-Kubitza

schemas/util.sql: added regprocedure(text)

12374 02/23/2014 03:11 PM Aaron Marcuse-Kubitza

schemas/util.sql: func2regproc*(): removed func2* so that this has the format of a cast function (which it is)

12373 02/23/2014 03:10 PM Aaron Marcuse-Kubitza

schemas/util.sql: added func2regproc(regprocedure)

12372 02/23/2014 03:08 PM Aaron Marcuse-Kubitza

schemas/util.sql: added func2regprocedure(regproc)

12371 02/23/2014 02:51 PM Aaron Marcuse-Kubitza

schemas/util.sql: added quote_typed()

12370 02/23/2014 01:30 PM Aaron Marcuse-Kubitza

schemas/util.sql: remake_diff_table(): use util.append_comment() instead of util.set_comment() to allow other functions to add comments to the diff table

12369 02/23/2014 01:18 PM Aaron Marcuse-Kubitza

schemas/util.sql: added append_comment(regclass)

12368 02/23/2014 01:00 PM Aaron Marcuse-Kubitza

schemas/util.sql: added comment(oid)

12364 02/23/2014 12:03 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: drop_relation(text), rename_relation(text, text): appended _esc to params that should be passed in escaped, and _name to those that shouldn't

12363 02/23/2014 12:00 PM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: rename_relation(): need quote_ident() around to_

12362 02/23/2014 11:39 AM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: truncated_prefixed_name_regexp(): need to match the entire string, so that the regexp can be used with util.replace_suffix()

12361 02/23/2014 11:37 AM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: truncated_prefixed_name_regexp(): need to pass max_prefix_len to util.name_was_truncated() because although the name itself might not have been truncated, it might become truncated once prefixed

12360 02/23/2014 11:32 AM Aaron Marcuse-Kubitza

schemas/util.sql: name_was_truncated(): support max_prefix_len param to determine truncation of something that will be prefixed

12359 02/23/2014 11:22 AM Aaron Marcuse-Kubitza

fix: name_was_truncated(): should use util.namedatalen() instead of hardcoding the value

12358 02/22/2014 08:35 PM Aaron Marcuse-Kubitza

schemas/util.sql: replace_suffix(): support strings that have been truncated (eg. as a table name) due to the prepending of a prefix

12357 02/22/2014 08:32 PM Aaron Marcuse-Kubitza

schemas/util.sql: added truncated_prefixed_name_regexp()

12356 02/22/2014 08:12 PM Aaron Marcuse-Kubitza

schemas/util.sql: added rtrim_n()

12355 02/22/2014 07:58 PM Aaron Marcuse-Kubitza

schemas/util.sql: added name_was_truncated()

12354 02/22/2014 07:56 PM Aaron Marcuse-Kubitza

schemas/util.sql: added namedatalen()

12353 02/22/2014 07:21 PM Aaron Marcuse-Kubitza

schemas/util.sql: drop_relation(regclass), rename_relation(regclass): use util.qual_name() instead of ::text so that the schema qualifier is always included in the debug SQL

12350 02/22/2014 07:11 PM Aaron Marcuse-Kubitza

schemas/util.sql: added replace_suffix()

12349 02/22/2014 06:47 PM Aaron Marcuse-Kubitza

schemas/util.sql: added rename_relation(regclass/text, text)

12348 02/22/2014 06:23 PM Aaron Marcuse-Kubitza

fix: schemas/util.sql: drop_relation(): documented that it is actually not idempotent, because the regclass will not be valid after the relation is dropped

12347 02/22/2014 06:21 PM Aaron Marcuse-Kubitza

schemas/util.sql: drop_relation(relation text, type text): put type param first because it is usually constant

12346 02/22/2014 06:12 PM Aaron Marcuse-Kubitza

schemas/util.sql: drop_table(), drop_view(): use drop_relation(relation text, type text)

12345 02/22/2014 06:10 PM Aaron Marcuse-Kubitza

schemas/util.sql: drop_relation(regclass): use simpler drop_relation(relation text, type text)

12344 02/22/2014 06:06 PM Aaron Marcuse-Kubitza

schemas/util.sql: added relation_type(regclass)

12343 02/22/2014 06:04 PM Aaron Marcuse-Kubitza

schemas/util.sql: added drop_relation(relation text, type text)

12342 02/22/2014 06:01 PM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: drop_relation(): need to pass force param to util.drop_*()

12341 02/22/2014 05:50 PM Aaron Marcuse-Kubitza

schemas/util.sql: added relation_type_char(regclass)

12340 02/22/2014 05:50 PM Aaron Marcuse-Kubitza

bugfix: schemas/util.sql: relation_type(character): must use "char" type for single character, as character actually allows multiple characters. corrected return type.

12339 02/22/2014 05:47 PM Aaron Marcuse-Kubitza

schemas/util.sql: added relation_type(character)

12334 02/22/2014 03:35 PM Aaron Marcuse-Kubitza

schemas/util.sql: schema_matches(): should be IMMUTABLE, not STABLE, because it uses only parameter values